Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(windows): resource_dir() return \\\?\\ prefix symbols #10093

Closed
wants to merge 1 commit into from

Conversation

olexiyb
Copy link
Contributor

@olexiyb olexiyb commented Jun 19, 2024

handle.path().resource_dir() gives unexpected folder started with "\\?\" due to current behavior of std::env::current_exe() described in rust-lang/rust#99931

This does not allow the use of the folder in scripts or other programs called in Tauri application.

due to rust feature on windows rust-lang/rust#99931 use dunce::canonicalize() to get proper name
@olexiyb olexiyb requested a review from a team as a code owner June 19, 2024 12:02
@amrbashir
Copy link
Member

This is the default behavior of Rust, and since this API is used in Rust, I think it should stay as is and if users want to remove the UNC prefix, they should use dunce, we only remove UNC prefix in tauri if it is being sent to JS.

@olexiyb
Copy link
Contributor Author

olexiyb commented Jun 30, 2024

Can we have a second function to get resource dir with UNC prefix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants